Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: try to fix ci issue #396

Merged
merged 7 commits into from
Dec 30, 2024
Merged

chore: try to fix ci issue #396

merged 7 commits into from
Dec 30, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 29, 2024

No description provided.

@Fdawgs
Copy link
Member

Fdawgs commented Dec 29, 2024 •
edited
Loading

As it's only Windows Node 22 failing I assume it's related to fastify/fastify#5889?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 29, 2024

it seems that we are using 22.11.0 in the ci for win.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 29, 2024

@Fdawgs

This seems to fix it. PTAL

mcollina
mcollina approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 12c9b1a into master Dec 30, 2024
13 checks passed
@Uzlopak Uzlopak deleted the fix-win-error-or-use-native-fetch branch December 30, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @Fdawgs @mcollina